Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3920: Removed broken sites #7106

Conversation

ivanskodje
Copy link
Contributor

@ivanskodje ivanskodje commented May 22, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Removed unsupported/broken sites:
viafree.se
viafree.dk
viafree.no
viasat4play.no
tv3play.no
tv8play.se
tv6play.se
tv3play.se
tv3play.dk
tv10play.se
play.nova.bg

Fixes #3920

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at e5a60dd

Summary

🗑️🔥🧹

Remove obsolete and unused code for Viafree and other TVPlay sites. Update documentation and module imports accordingly.

Some extractors were no longer needed
So from the codebase they were deleted
ViafreeIE and more
Were shown to the door
And the docs and imports were updated

Walkthrough

viafree.se
viafree.dk
viafree.no
viasat4play.no
tv3play.no
tv8play.se
tv6play.se
tv3play.se
tv3play.dk
tv10play.se
play.nova.bg
@ivanskodje ivanskodje changed the title 3920: Removed unsupported sites 3920: Removed broken sites May 22, 2023
@Grub4K
Copy link
Member

Grub4K commented May 22, 2023

Why are they removed and not fixed instead?

@ivanskodje
Copy link
Contributor Author

ivanskodje commented May 23, 2023

Why are they removed and not fixed instead?

Pluto.tv have bought and taken over these URLs (already got an extractor plutotv.py):

  • viafree.se
  • viafree.dk
  • viafree.no

Does not exist anymore:

  • viasat4play.no
  • tv3play.no
  • tv8play.se
  • tv6play.se
  • tv3play.se
  • tv3play.dk
  • tv10play.se

play.nova.bg already have an extractor at noveplay.py, and was removed from tvplay.py

Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pluto.tv have bought and taken over these URLs (already got an extractor plutotv.py):

  • viafree.se
  • viafree.dk
  • viafree.no

Should these be added to plutotv's valid_url then?

supportedsites.md Outdated Show resolved Hide resolved
@ivanskodje
Copy link
Contributor Author

ivanskodje commented May 23, 2023

Pluto.tv have bought and taken over these URLs (already got an extractor plutotv.py):

  • viafree.se
  • viafree.dk
  • viafree.no

Should these be added to plutotv's valid_url then?

Probably not, as the old video URLs does not redirect anywhere (I am getting a 403). If you are using plutotv you would only work with plutotv URLs anyway and would have no need for supporting the old URLs which I suspect was for a different web-site which is not related to plutotv (I am not sure).

@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@pukkandan pukkandan merged commit 9372644 into yt-dlp:master May 29, 2023
11 checks passed
@ivanskodje ivanskodje deleted the 3920-removed-sites-and-extractor-for-viafree branch May 30, 2023 10:47
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extractor for Viafree and more sites
3 participants