Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/twitter:spaces] Add scheduled time (release_timestamp) for live spaces #7186

Merged
merged 3 commits into from Jun 1, 2023
Merged

Conversation

CeruleanSky
Copy link
Contributor

@CeruleanSky CeruleanSky commented Jun 1, 2023

Description of your pull request and other information

Add scheduled start time for spaces

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at bb3b3b1

Summary

馃晵馃攰馃惁

Add support for extracting release timestamps from Twitter Spaces audio streams. Use the release_timestamp field in yt_dlp/extractor/twitter.py to store the scheduled start time of the stream.

Oh we're the coders of the Twitter Spaces
We stream the audio from many places
We add release_timestamp to the streams
To schedule them ahead, so we can dream

Walkthrough

  • Extract the scheduled start time of Twitter Spaces audio streams and convert it to Unix timestamp (link)
  • Add the extracted start time as release_timestamp field to the info dictionary of the audio streams (link)

Add scheduled start time for spaces
@CeruleanSky CeruleanSky changed the title [extractor/twitter:spaces] [extractor/twitter:spaces] Add scheduled time (release_timestamp) for live spaces Jun 1, 2023
@pukkandan
Copy link
Member

Add/update test

yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
@pukkandan pukkandan merged commit 1c16d9d into yt-dlp:master Jun 1, 2023
11 checks passed
@pukkandan
Copy link
Member

Next time, pls actually follow this

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants