New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/zingmp3]: add live radio extractor #7189
Merged
bashonly
merged 36 commits into
yt-dlp:master
from
hatienloi:zingmp3/add_live_radio_extractor
Nov 16, 2023
Merged
[extractor/zingmp3]: add live radio extractor #7189
bashonly
merged 36 commits into
yt-dlp:master
from
hatienloi:zingmp3/add_live_radio_extractor
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingmp3/add_live_radio_extractor
…ingmp3/add_live_radio_extractor
Huh? Did you intend to close this? |
HI, i got some issue, i need more time to update code again, i will fix and reopen PR again. Thanks you. |
Hi @pukkandan . Please help me review this PR |
seproDev
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long for someone to take a look at this
bashonly
requested changes
Nov 15, 2023
bashonly
approved these changes
Nov 16, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: hatienl0i261299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
ADD DESCRIPTION HERE
Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 3bfcf17
Summary
🎙️🇻🇳🆕
This pull request enhances the
zingmp3
extractor to support live radio and podcasts from zingmp3.vn. It adds new extractor classes for different types of radio and podcast URLs and modifies existing classes to handle the new API responses. It also updates the_extractors.py
file to register the new classes.Walkthrough
ZingMp3IE
class to also handle podcast episode URLs and extract their streaming URLs and metadata (link, link, link, link)ZingMp3AlbumIE
class to also handle podcast program URLs and extract their metadata and entries (link)ZingMp3ChartHomeIE
class to also handle top 100 songs, podcast discovery, and podcast categories URLs and extract their metadata and entries (link, link)ZingMp3UserIE
class to also handle new release songs and albums URLs and extract their metadata and entries (link, link, link)ZingMp3BaseIE
class to provide the necessary URLs for the new classes and types of media and pages (link, link)zingmp3.py
to includeExtractorError
from..utils
for error handling in the new classes (link)