Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/zingmp3]: add live radio extractor #7189

Merged
merged 36 commits into from Nov 16, 2023

Conversation

hatienloi
Copy link
Contributor

@hatienloi hatienloi commented Jun 1, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 3bfcf17

Summary

🎙️🇻🇳🆕

This pull request enhances the zingmp3 extractor to support live radio and podcasts from zingmp3.vn. It adds new extractor classes for different types of radio and podcast URLs and modifies existing classes to handle the new API responses. It also updates the _extractors.py file to register the new classes.

We're sailing on the zingmp3 sea, with songs and podcasts galore
We've added new extractors, to fetch them from the shore
ZingMp3LiveRadioIE and ZingMp3PostCastEpisodeIE
We'll heave away and haul them in, on the count of one, two, three

Walkthrough

  • Add four new classes to support live radio and podcast extraction from zingmp3.vn (link, link)
  • Modify the ZingMp3IE class to also handle podcast episode URLs and extract their streaming URLs and metadata (link, link, link, link)
  • Modify the ZingMp3AlbumIE class to also handle podcast program URLs and extract their metadata and entries (link)
  • Modify the ZingMp3ChartHomeIE class to also handle top 100 songs, podcast discovery, and podcast categories URLs and extract their metadata and entries (link, link)
  • Modify the ZingMp3UserIE class to also handle new release songs and albums URLs and extract their metadata and entries (link, link, link)
  • Add more API endpoints to the ZingMp3BaseIE class to provide the necessary URLs for the new classes and types of media and pages (link, link)
  • Modify the import statement in zingmp3.py to include ExtractorError from ..utils for error handling in the new classes (link)

@hatienloi hatienloi closed this Jun 1, 2023
@hatienloi hatienloi reopened this Jun 1, 2023
@hatienloi hatienloi closed this Jun 1, 2023
@gamer191
Copy link
Collaborator

gamer191 commented Jun 1, 2023

Huh? Did you intend to close this?

@gamer191 gamer191 added the closed-pr (Partially) valid PR that was closed by OP label Jun 1, 2023
@hatienloi
Copy link
Contributor Author

Huh? Did you intend to close this?

HI, i got some issue, i need more time to update code again, i will fix and reopen PR again. Thanks you.

@hatienloi hatienloi reopened this Jun 4, 2023
@pukkandan pukkandan removed the closed-pr (Partially) valid PR that was closed by OP label Jun 4, 2023
@bashonly bashonly added the site-request Request to support a new website label Jun 14, 2023
@bashonly bashonly self-requested a review September 27, 2023 15:26
@hatienloi
Copy link
Contributor Author

Hi @pukkandan . Please help me review this PR

Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for someone to take a look at this

yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Nov 7, 2023
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zingmp3.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Nov 16, 2023
@bashonly bashonly merged commit 64de1a4 into yt-dlp:master Nov 16, 2023
15 checks passed
@hatienloi hatienloi deleted the zingmp3/add_live_radio_extractor branch November 17, 2023 09:53
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants