Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitalConcertHall] Support for Films #7202

Merged
merged 2 commits into from Jun 2, 2023

Conversation

ItzMaxTV
Copy link
Contributor

@ItzMaxTV ItzMaxTV commented Jun 2, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

The PR adds support for films to an existing extractor that previously only supported concerts.

Fixes #7184

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 33df3da

Summary

🎥🎼🛠️

Improve the Digital Concert Hall extractor by adding support for different video types and more metadata. Update tests accordingly.

film or concert, we don't care, we just want to rock
We scrape the hall for every bit of metadata we can unlock
We split the concert into chapters, we don't miss a note
We test our code with film videos, we make the extractor float

Walkthrough

  • Update _VALID_URL regex to support film and concert types of videos (link)
  • Add a new test case for a film type video with expected metadata (link)
    • Extract type_ group from URL and use it to request appropriate JSON data from API (link)
    • Handle different structures of videos list for film and concert videos (link)
    • Pass type_ parameter to _entries method (link)
    • Accept type_ parameter and use it to conditionally extract chapters field from cuepoints key of each video item (link, link)
    • Return a list of entries with video metadata and formats (link)

yt_dlp/extractor/digitalconcerthall.py Outdated Show resolved Hide resolved
@pukkandan pukkandan merged commit 55ed4ff into yt-dlp:master Jun 2, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DigitalConcertHall] cannot download videos under /films
2 participants