[extractor/motherless] Adding Gallery and fixing #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't use |
|
@pukkandan, could you allow the tests to run again? |
|
@pukkandan, tests pass. Let me know if there's anything else that needs to be done. |
|
@bashonly @pukkandan, anything additional that needs to be done on this? Should this be marked as needs review? |
bashonly
requested changes
Jun 18, 2023
rexlambert22
commented
Jun 20, 2023
* Exception for abstract method * Try to avoid matching videos from groups or galleries using regex only Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
* Category extraction improved * Fix a test case * Reverted changes to uploader and comment count extraction
bashonly
approved these changes
Jun 20, 2023
bashonly
added
pending-review
pukkandan
reviewed
Jun 21, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
pukkandan
approved these changes
Jun 21, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: rexlambert22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds motherless galleries as a playlist type and improves motherless extractor generally.
Based on PR #3948 but that is dead and, at least at this point, doesn't work.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 9d0fb58
Summary
🚀🗣️🔒
Add support for
--write-linkand--write-urloptions to write video or playlist URLs to a file. Refactor the code for writing metadata files to avoid duplication and improve readability.Walkthrough