Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acast: fix test data, support embeds in other pages #7212

Merged
merged 2 commits into from Jun 4, 2023

Conversation

pabs3
Copy link
Contributor

@pabs3 pabs3 commented Jun 3, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fix the acast extractor test data and add support for checking web pages for embeds.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at cb8a488

Summary

🐛🛠️🌐

Fix and enhance acast extractor. Allow extraction from embedded players by adding _EMBED_REGEX and _WEBPAGE_TESTS to ACastIE in yt_dlp/extractor/acast.py.

Sing, O Muse, of the skillful coder who refined the ACastIE class
And made it fit to parse the webpages where the podcasts are enmassed
He changed the _VALID_URL to match the acast domain and path
And added _EMBED_REGEX and _WEBPAGE_TESTS to aid his craft

Walkthrough

  • Rename and update _VALID_URL attribute and add _EMBED_REGEX attribute to ACastIE class (link, link)
  • Add _WEBPAGE_TESTS attribute to ACastIE class (link)

Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use (?x:pattern) syntax instead of adding an intermediate variable

@pukkandan
Copy link
Member

In future, pls avoid force-pushing. Unclean history is fine.

@pukkandan pukkandan merged commit c91ac83 into yt-dlp:master Jun 4, 2023
11 checks passed
@pabs3
Copy link
Contributor Author

pabs3 commented Jun 4, 2023 via email

@pabs3 pabs3 deleted the acast branch January 13, 2024 04:32
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants