Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/tencent] Fix fatal metadata extraction #7219

Merged
merged 2 commits into from Jun 4, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Jun 3, 2023

Update regex pattern, use _search_json to make metadata extraction actually non-fatal

Closes #7177

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at b6f0e8c

Summary

🛠️🆙🚫

Improved Tencent video extraction in yt_dlp/extractor/tencent.py. Used a better JSON parser and updated tests.

Tencent videos
Metadata and formats parsed
Winter tests skipped

Walkthrough

  • Simplify metadata extraction using _search_json helper method (link)
  • Update md5 values of test cases to match current checksums of downloaded files (link, link)
  • Skip test case for unavailable video (link)
  • Skip m3u8 format download for encrypted video in test case (link)

@bashonly bashonly added the site-bug Issue with a specific website label Jun 3, 2023
@bashonly bashonly merged commit 971d901 into yt-dlp:master Jun 4, 2023
12 checks passed
@bashonly bashonly deleted the fix/tencent branch June 4, 2023 12:03
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tencent video failed
2 participants