New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add funker530 extractor #7291
add funker530 extractor #7291
Conversation
Ok, we're good to go! |
Funker530 is a little weird because YouTube videos can be embedded. For example, https://funker530.com/video/theres-far-more-than-meets-the-eye-territory-shifts/ |
So it looks like the site either embeds Rumble videos or embeds Youtube videos? Generic ( diff --git a/yt_dlp/extractor/rumble.py b/yt_dlp/extractor/rumble.py
index 98f660f8b..82f3f0f8c 100644
--- a/yt_dlp/extractor/rumble.py
+++ b/yt_dlp/extractor/rumble.py
@@ -144,7 +144,7 @@ def _extract_embed_urls(cls, url, webpage):
if embeds:
return embeds
return [f'https://rumble.com/embed/{mobj.group("id")}' for mobj in re.finditer(
- r'<script>\s*Rumble\(\s*"play"\s*,\s*{\s*[\'"]video[\'"]\s*:\s*[\'"](?P<id>[0-9a-z]+)[\'"]', webpage)]
+ r'<script>[^<]*\bRumble\(\s*"play"\s*,\s*{\s*[\'"]?video[\'"]?\s*:\s*[\'"](?P<id>[0-9a-z]+)[\'"]', webpage)]
def _real_extract(self, url):
video_id = self._match_id(url) So there's no need to reinvent the RumbleEmbed extractor inside the funker530 extractor. However, If there is valuable metadata in the funker530 webpage that is missing from Rumble or Youtube (e.g. P.S. please review this again |
Will do. |
I just called the individual Rumble and YouTube extractors and return their output rather than returning a |
If you return only a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed changes
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com> Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Authored by: Cyberes
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Added extractor for
funker530.com
. Extracts thumbnail, description, and metadata. Passes tests.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at 1177d8e
Summary
馃帴馃啎馃悵
Add support for Funker530 video extraction. Create a new
funker530.py
module with aFunker530IE
class that handles the extraction logic and imports it in_extractors.py
.Walkthrough
Funker530IE
class fromfunker530.py
module in_extractors.py
(link)Funker530IE
class infunker530.py
module (link)