Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/ximalaya] use the normal sort order #7292

Merged
merged 1 commit into from Jun 12, 2023

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Jun 12, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

The sort=1 reverses the sort order of the playlist so that the last track is downloaded first. I don't know why this was added but the user has to download all tracks to get the first one.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 7b3e24d

Summary

馃悰馃毇馃幍

Removed sort parameter from ximalaya.py extractor to fix missing tracks issue. This parameter caused some tracks to be skipped or duplicated in some albums.

sort parameter
gone from tracks list query
no more missing songs

Walkthrough

  • Remove sort parameter from tracks list query to fix missing tracks issue (link)

@pukkandan
Copy link
Member

@lockmatrix Any opinion? since it's your code.

@lockmatrix
Copy link
Contributor

lockmatrix commented Jun 12, 2023

@lockmatrix Any opinion? since it's your code.

It's ok.

Personally, I tend to download the newest one first.

@pukkandan
Copy link
Member

Looks like the site itself sorts in reverse order? Is there a URL to get the webpage with normal sorting?

@linsui
Copy link
Contributor Author

linsui commented Jun 12, 2023

It's in the normal sorting by default for me, e.g. https://www.ximalaya.com/album/43074442. I thought I can't reverse the order without logging in.

@pukkandan
Copy link
Member

pukkandan commented Jun 12, 2023

But http://www.ximalaya.com/61425525/album/5534601/ is reversed, weird. ANyway, since lockmatrix doesn't mind, let's go with this.

@pukkandan pukkandan merged commit 8790ea7 into yt-dlp:master Jun 12, 2023
12 checks passed
@linsui linsui deleted the patch-1 branch June 12, 2023 08:08
@linsui
Copy link
Contributor Author

linsui commented Jun 12, 2023

Thanks!

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants