Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripchat: update m3u8 url #7306

Merged
merged 3 commits into from Jun 15, 2023
Merged

stripchat: update m3u8 url #7306

merged 3 commits into from Jun 15, 2023

Conversation

foreignBlade
Copy link
Contributor

@foreignBlade foreignBlade commented Jun 14, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fix the m3u8 url with the new format. For example

https://b-hls-23.doppiocdn.com/hls/92893973/92893973.m3u8?playlistType=lowLatency&_HLS_msn=3486&_HLS_part=0

ADD DESCRIPTION HERE

Fixes #7305

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at c27905b

Summary

🛠️🎥🆔

Fix HLS stream extraction for Stripchat by using model ID playlist instead of master playlist in yt_dlp/extractor/stripchat.py.

HLS stream URL
changed to use model ID -
fixes missing parts

Walkthrough

  • Fix HLS stream URL to use model ID instead of master playlist (link)

Fix the m3u8 url with the new format
@bashonly
Copy link
Member

you are reverting the url change from this PR: https://github.com/yt-dlp/yt-dlp/pull/5985/files#diff-30808664de0951cafc7f7521d5ac7bdc79fc05c81554ad6bcf5e3f5f234cb44eL47

it was changed because it is not the master manifest, it is a single variant (single resolution). can you find the master m3u8 url?

@bashonly bashonly added NSFW site-bug Issue with a specific website labels Jun 14, 2023
@pukkandan pukkandan added do-not-merge pending-fixes PR has had changes requested and removed do-not-merge labels Jun 14, 2023
@mikeymatrix70
Copy link

Before I new there was an extractor to pull these I was manually getting the manifest URL.
for https://b-hls-23.doppiocdn.com/hls/92893973/92893973.m3u8?playlistType=lowLatency&_HLS_msn=3486&_HLS_part=0 the manifest url (master) would be
https://b-hls-23.doppiocdn.com/hls/92893973/master/92893973_auto.m3u8
I always change the domain to edge-hls.doppiocdn.com and it always works, Had been doing this as xHamsterLive which uses the same feeds didn't have an extractor. So to download that url I would use https://edge-hls.doppiocdn.com/hls/92893973/master/92893973_auto.m3u8 Hopefully someone can implement fix and also add xHamsterLive as an extractor

foreignBlade and others added 2 commits June 14, 2023 17:51
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Jun 14, 2023
@foreignBlade
Copy link
Contributor Author

@mikeymatrix70 I realize that my credentials for spankbanglive work with stripchat, but not with xhamsterlive. But I would also like to see something that can download from "Collection".

@bashonly bashonly merged commit f9213f8 into yt-dlp:master Jun 15, 2023
11 checks passed
@bashonly bashonly removed the pending-review PR needs a review label Jun 15, 2023
@pro-ject143
Copy link

@bashonly Thanks for pointing out difference between yt-dlp and WM Recorder on Thursday. I understand now, and now using yt-dlp to download streams.

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripchat: Error: No active streams found
5 participants