Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N1] Fix extractor for new player #7373

Merged
merged 9 commits into from Sep 18, 2023
Merged

[N1] Fix extractor for new player #7373

merged 9 commits into from Sep 18, 2023

Conversation

u-spec-png
Copy link
Contributor

@u-spec-png u-spec-png commented Jun 21, 2023

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes N1 extractor for new player on newer articles.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at fe10f99

Summary

馃寪馃幀馃悰

Improve N1Info extractor to handle different domains and player, and fix thumbnail issue. Add yt_dlp/extractor/n1.py test.

N1Info expands
Domains and player updated
Thumbnail fixed - fall

Walkthrough

  • Updated the URL regex to support more domains for N1Info (link)
  • Added extraction logic for the new Brid player, which uses JSON data and m3u8 formats (link)
  • Fixed thumbnail extraction by using the correct meta tag (link)
  • Kept the old extraction logic for the video tag for backward compatibility (link)
  • Added a test case for a URL that uses the new Brid player (yt_dlp/extractor/n1.py) (link)

@u-spec-png u-spec-png changed the title [N1] Fix Extractor for new player [N1] Fix extractor for new player Jun 21, 2023
@bashonly bashonly added the site-bug Issue with a specific website label Jun 21, 2023
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Show resolved Hide resolved
@pukkandan pukkandan added the pending-fixes PR has had changes requested label Jun 22, 2023
u-spec-png and others added 5 commits June 22, 2023 13:18
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Jun 22, 2023
@bashonly bashonly self-requested a review September 17, 2023 13:32
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
yt_dlp/extractor/n1.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-review PR needs a review labels Sep 17, 2023
@bashonly bashonly merged commit 8ac5b6d into yt-dlp:master Sep 18, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants