Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pornbox] New extractor #7386

Merged
merged 23 commits into from Sep 18, 2023
Merged

[Pornbox] New extractor #7386

merged 23 commits into from Sep 18, 2023

Conversation

niemands
Copy link
Contributor

@niemands niemands commented Jun 22, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This extractor adds support for videos on pornbox.com. Most of the videos on the site must be purchased individually or are accessible via channel membership options. The test case is for one of the few free promotional videos. However, it still requires an account.
This extractor can return metadata with --dump-json and --ignore-no-formats, but otherwise requires cookie authentication.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 6ff3131

Summary

馃殌馃棧锔忦煕狅笍

Add support for --write-link and --write-url options to write video or playlist URLs to a file. Refactor the code for writing metadata files to avoid duplication and improve readability.

get and set methods
refactored for readability
autumn leaves falling

Walkthrough

  • Add new extractors for various video platforms (F0L

@bashonly bashonly added site-request Request to support a new website NSFW labels Jun 22, 2023
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added the pending-fixes PR has had changes requested label Jun 22, 2023
niemands and others added 4 commits June 23, 2023 01:31
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
niemands and others added 2 commits June 23, 2023 11:46
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Jun 23, 2023
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
yt_dlp/extractor/pornbox.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-review PR needs a review label Sep 17, 2023
@niemands
Copy link
Contributor Author

niemands commented Sep 18, 2023

Thank you for re-visiting my PR. I had to replace the first test case with a new video because the old one was no longer available, and as far as I can see this is one of the four remaining free videos, so I'm not sure if this test case will work for long. However, it passes the test.

@bashonly bashonly removed the pending-review PR needs a review label Sep 18, 2023
@bashonly bashonly merged commit 4099946 into yt-dlp:master Sep 18, 2023
16 checks passed
@niemands niemands deleted the pornbox branch September 19, 2023 16:39
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants