New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pornbox] New extractor #7386
[Pornbox] New extractor #7386
Conversation
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com> Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicks
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com> Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Thank you for re-visiting my PR. I had to replace the first test case with a new video because the old one was no longer available, and as far as I can see this is one of the four remaining free videos, so I'm not sure if this test case will work for long. However, it passes the test. |
Authored by: niemands
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This extractor adds support for videos on pornbox.com. Most of the videos on the site must be purchased individually or are accessible via channel membership options. The test case is for one of the few free promotional videos. However, it still requires an account.
This extractor can return metadata with
--dump-json
and--ignore-no-formats
, but otherwise requires cookie authentication.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at 6ff3131
Summary
馃殌馃棧锔忦煕狅笍
Add support for
--write-link
and--write-url
options to write video or playlist URLs to a file. Refactor the code for writing metadata files to avoid duplication and improve readability.Walkthrough