Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdultSwim] fix ignoring subtitles warning #7421

Merged
merged 1 commit into from Jun 25, 2023
Merged

[AdultSwim] fix ignoring subtitles warning #7421

merged 1 commit into from Jun 25, 2023

Conversation

nnoboa
Copy link
Contributor

@nnoboa nnoboa commented Jun 25, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes #6191

This PR fixes a warning message stating "subtitle tracks found in the HLS manifest" are being ignored, following the change suggested in the issue.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 47fdc67

Summary

馃帪锔忦煑o笍馃攢

Improve subtitle extraction and merging for adultswim extractor. Use m3u8 source to get subtitles and combine them with existing ones.

Extract m3u8 formats
Subtitles join the info dict
Autumn of merging

Walkthrough

  • Extract subtitles from m3u8 formats and merge them with existing subtitles (link)

@pukkandan pukkandan merged commit 5e16cf9 into yt-dlp:master Jun 25, 2023
12 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AdultSwim] Ignoring subtitle tracks found in the HLS manifest
2 participants