Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/youtube:tab] Support short renderers in playlists #7425

Merged
merged 2 commits into from Jun 29, 2023

Conversation

coletdjnz
Copy link
Member

@coletdjnz coletdjnz commented Jun 26, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Note: YouTube doesn't give continuations yet for shorts view, so will only get 100 videos

Fixes #7424

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at f9bc450

Summary

🎞️🧪⚠️

Improve YouTube tab page extraction and testing. Handle shorts playlists, pagination, and hidden videos in yt_dlp/extractor/youtube.py.

Sing, O Muse, of the skillful coder who devised
A way to pluck from YouTube's tab pages the varied prizes
Of shorts and playlists, and who tested his creation well
And warned of hidden videos, like Cerberus at the gates of hell

Walkthrough

  • Add support for extracting entries from richGridRenderer in YouTube tab pages (link)
  • Add test case for playlist of shorts in yt_dlp/extractor/youtube.py (link)

Note: YouTube doesn't give continuations yet for shorts view
Fixes yt-dlp#7424

Authored by: coletdjnz
@coletdjnz coletdjnz changed the title [extractor/youtube:tab] Support short renderes in playlists [extractor/youtube:tab] Support short renderers in playlists Jun 26, 2023
yt_dlp/extractor/youtube.py Outdated Show resolved Hide resolved
yt_dlp/extractor/youtube.py Outdated Show resolved Hide resolved
@coletdjnz coletdjnz merged commit fcbc9ed into yt-dlp:master Jun 29, 2023
11 checks passed
@coletdjnz coletdjnz deleted the fix/yt-playlist-shorts branch June 29, 2023 23:26
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Fixes yt-dlp#7424

Authored by: coletdjnz
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[YouTube] Channel playlist link in UU format doesn't download any videos
2 participants