Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/youtube:stories] Remove YoutubeStoriesIE #7459

Merged
merged 3 commits into from Jul 6, 2023

Conversation

coletdjnz
Copy link
Member

@coletdjnz coletdjnz commented Jun 29, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

stories is dead

https://www.theverge.com/2023/5/25/23736246/youtube-ending-stories-shorts-community-posts
https://techcrunch.com/2023/05/25/youtube-stories-are-shutting-down-june-26-as-company-focuses-on-shorts/

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 5731604

Summary

🗑️🔧🚫

Drop YouTube stories support from yt-dlp. Delete the YoutubeStoriesIE class and related code from yt_dlp/extractor/youtube.py.

Sing, O Muse, of the daring deeds of yt-dlp,
The swift and versatile downloader of online videos,
Who faced the wrath of YouTube and its fleeting stories,
And boldly stripped them from his code with skillful strokes.

Walkthrough

  • Remove YoutubeStoriesIE extractor and related code, as YouTube stories are no longer available (link, link, F0L7439R

@pukkandan
Copy link
Member

Also do:

diff --git a/yt_dlp/extractor/youtube.py b/yt_dlp/extractor/youtube.py
index d5607975e..66eca7198 100644
--- a/yt_dlp/extractor/youtube.py
+++ b/yt_dlp/extractor/youtube.py
@@ -3612,7 +3612,7 @@ def _extract_player_response(self, client, video_id, master_ytcfg, player_ytcfg,
         yt_query = {
             'videoId': video_id,
         }
-        if smuggled_data.get('is_story') or _split_innertube_client(client)[0] == 'android':
+        if _split_innertube_client(client)[0] == 'android':
             yt_query['params'] = self._PLAYER_PARAMS

         yt_query.update(self._generate_player_context(sts))
@@ -4025,8 +4025,6 @@ def _download_player_responses(self, url, smuggled_data, video_id, webpage_url):
         webpage = None
         if 'webpage' not in self._configuration_arg('player_skip'):
             query = {'bpctr': '9999999999', 'has_verified': '1'}
-            if smuggled_data.get('is_story'):  # XXX: Deprecated
-                query['pp'] = self._PLAYER_PARAMS
             webpage = self._download_webpage(
                 webpage_url, video_id, fatal=False, query=query)

@pukkandan pukkandan merged commit 90db9a3 into yt-dlp:master Jul 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants