Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EmbedThumbnail] Support m4v Extention #7583

Merged
merged 1 commit into from Jul 13, 2023

Conversation

Neurognostic
Copy link
Contributor

@Neurognostic Neurognostic commented Jul 13, 2023

Support m4v Extention

Some platforms can serve m4v for mpeg video, this commit simply adds support for embedding thumbnails into m4v files.

Tested with both AtomicParsley and Mutagen. It is possible that m4v files could include DRM, but I don't have any DRM m4v files to test on. The existing error handling should probably be fine in those cases.

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 1bbf619

Summary

馃帪锔忦焼曫煕狅笍

Add thumbnail embedding for m4v files and improve error message. This allows users to embed thumbnails in more video formats and get clearer feedback on unsupported ones.

Sing, O Muse, of the skillful coder who devised
A way to adorn the m4v files with fair thumbnails
Like the cunning Hephaestus who forged the shield of Achilles
With many a splendid image of gods and men in battle.

Walkthrough

  • Add support for embedding thumbnails in m4v files by modifying the file extension check (link)
  • Update the error message for unsupported filetypes to include m4v (link)

Some platforms can serve m4v for mpeg video, this commit simply
adds support for embedding thumbnails into m4v files.

Tested with both AtomicParsley and Mutagen. It is possible that
m4v files could include DRM, but I don't have any DRM m4v files
to test on. The existing error handling should probably be fine
in those cases.
@pukkandan pukkandan merged commit 8a4cd12 into yt-dlp:master Jul 13, 2023
14 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants