New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/pbskids] Add support for pbskids.org videos #7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snixon
changed the title
[extractors/pbskids] Add support for pbskids.org videos
[extractor/pbskids] Add support for pbskids.org videos
Jul 15, 2023
pukkandan
requested changes
Jul 16, 2023
bashonly
added
site-request
Request to support a new website
pending-fixes
PR has had changes requested
labels
Jul 16, 2023
Ahh thank you, I was wondering if there was a better way to trawl out that json Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Thanks for the review! |
pukkandan
reviewed
Jul 16, 2023
bashonly
requested changes
Jul 16, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Jul 18, 2023
@pukkandan Could you take a look? I've got the changes in place. Would you prefer a cleaner PR with just a single commit? |
The PR will be squashed upon merge, resulting in a single commit anyways. Do not worry about commit messages and amount of commits |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: snixon Fixes yt-dlp#2440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds support for videos on the pbskids.org site. I added it as a second extractor to the existing
extractor/pbs.py
, but if that's not appropriate I can split it out to its own file, it doesn't share any code with the existing extractor.I think I found all the proper convenience methods, passes flake8
Fixes #2440
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at ec225c9
Summary
馃殮馃馃搳
Added a new extractor for PBS Kids videos. The
PBSKidsIE
class inpbs.py
handles the JSON data from the PBS Kids website and extracts the video formats and metadata. The class is registered in_extractors.py
as a supported extractor.Walkthrough
PBSKidsIE
to handle PBS Kids videos (link)json
module andtraverse_obj
function to parse and access JSON data embedded in the webpage (link, link)PBSKidsIE
as a supported extractor in_extractors.py
(link)PBSKidsIE
(link)_extract_m3u8_formats_and_subtitles
to get the available formats and subtitles (link)