Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/MagellanTV] Add extractor #7616

Merged
merged 4 commits into from Jul 20, 2023
Merged

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Jul 16, 2023

Also improves utils.parse_duration so it can parse hrs? as hours

Closes #7529

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 9eb3193

Summary

馃寪馃帴馃晵

Add support for MagellanTV video extraction. Define a new MagellanTVIE class in magellantv.py and import it in _extractors.py. Adjust parse_duration in _utils.py to handle different hour formats.

MagellanTVIE
Extracts videos and formats
Autumn of learning

Walkthrough

  • Add support for extracting videos from MagellanTV website (link, link)
    • Import MagellanTVIE class from magellantv.py module in _extractors.py (link)
    • Define MagellanTVIE class in magellantv.py module, inheriting from InfoExtractor (link)
    • Implement _VALID_URL and _real_extract methods to handle MagellanTV URLs and extract video information and formats (link)
    • Define test cases for the extractor in magellantv.py module (link)
  • Modify parse_duration function in _utils.py to allow for more variations of the word "hours" in the input string (link)
    • Adjust regular expression pattern to match "h", "hrs", or "hours" in the input string (link)
    • This is to accommodate the format used by MagellanTV, which sometimes uses different abbreviations for hours (link)

@bashonly bashonly added the site-request Request to support a new website label Jul 16, 2023
@CHJ85
Copy link
Contributor

CHJ85 commented Jul 16, 2023

Thanks for your continued work!

@pukkandan
Copy link
Member

@bashonly Feel free to merge the utils fix as separate commit if you want.

@bashonly bashonly merged commit f4ea501 into yt-dlp:master Jul 20, 2023
13 checks passed
@bashonly bashonly deleted the extractor/magellantv branch December 7, 2023 15:13
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MagellanTV extractor plugin
3 participants