New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/douyutv] fix broken DouyuTV and DouyuShow #7652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
reviewed
Jul 23, 2023
bashonly
requested changes
Sep 18, 2023
bashonly
added
pending-fixes
PR has had changes requested
site-bug
Issue with a specific website
labels
Sep 18, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
requested changes
Sep 19, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Sep 19, 2023
coletdjnz
approved these changes
Sep 21, 2023
pukkandan
approved these changes
Sep 21, 2023
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#2494, Closes yt-dlp#7295 Authored by: c-basalt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Use PhantomJS to enable the use of new APIs to fix DouyuTV (live stream) and DouyuShow (videos).
Fixes #2494
Fixes #7295
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 0bd9507
Summary
🛠️📺🐛
Refactor and improve
douyutv.py
extractors. Create a new base classDouyuBaseIE
and use it forDouyuTVIE
andDouyuShowIE
. Fix format and metadata extraction for Douyu livestreams and VODs.Walkthrough
DouyuBaseIE
for common logic of Douyu extractors (link)DouyuTVIE
(link, link, link)DouyuTVIE
class that used the wrong variable for room id (link)DouyuShowIE
(link, link)