Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/cbc] Fix upgrade required #7689

Merged
merged 1 commit into from Sep 16, 2023
Merged

Conversation

makew0rld
Copy link
Contributor

@makew0rld makew0rld commented Jul 24, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

A temporary fix is obtained by allowed the upgrade status code to be accepted. The API still returns the information we want, just with the header status code 426 because clients should be updating to a newer API version with different paths.

Fixes #7477

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at a4dd709

Summary

🛠️🆙🚨

Fix CBC extractor by handling 426 status code. Update cbc.py to raise an ExtractorError when the CBC API requires a newer version.

_new_claims_token
Handles 426 error
Autumn of the API

Walkthrough

  • Fix CBC extractor by handling 426 status code and updating API version (link, F0L

@makew0rld makew0rld mentioned this pull request Jul 24, 2023
11 tasks
@bashonly bashonly added the site-bug Issue with a specific website label Jul 24, 2023
@bashonly bashonly added pending-review PR needs a review and removed pending-review PR needs a review labels Sep 14, 2023
@bashonly bashonly merged commit 9bf14be into yt-dlp:master Sep 16, 2023
14 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBC Gem Upgrade required
2 participants