[ie/tiktok] Fix audio-only format extraction #7712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
reviewed
Jul 28, 2023
| 'ext': 'mp3', | ||
| 'acodec': 'mp3', | ||
| 'ext': ext, | ||
| 'acodec': 'aac' if ext == 'm4a' else ext, |
There was a problem hiding this comment.
Many IEs incl youtube just sets acodec=m4a. So either's fine
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6608 Authored by: bashonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original patch only fixed slideshows w/ mp3 audio, not m4a formats. mb
Closes #6608
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at bd4d4b1
Summary
🎵🔄🎞️
Improved TikTok extractor to support more audio formats and metadata, and added tests for slideshow videos. Renamed
mp3_metatoaudio_metainyt_dlp/extractor/tiktok.pyand updated references.Walkthrough
mp3_metafunction toaudio_metato support more audio formats and metadata (link, link)skipkey to test case for unavailable video intiktok.py(link)md5,creator,artistandtrackfields of test case for video with mp3 format intiktok.py(link, link)tiktok.py(link)