Fixtests

[trainman261]

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixing tests as discussed in #7484 .
As many as possible were fixed. Despite this, many tests don't work for different reasons, in many cases the videos are no longer available, possibly geo-restricted, sometimes it's hard to tell. Those tests have all been marked with a skip. The tests, where the IE itself seems to be broken, have not been marked with a skip. This means a lot of tests are marked with a skip, though. Wherever I was able to find an alternative video, I did, but I wasn't often able to. If I should get rid of the skip tags, please let me know.
The fixes for the individual IEs have been also maintained in seperate branches and can be pulled separately if required (branches are named name-fixtests).
The following IE tests now all pass (or skip):

• AE networks (all IEs)
• AMC networks
• CBC: CBC Player, CBC Gem, CBC Gem Live, CBC Gem Playlist
• CBS (all IEs)
• CNBC: CNBC, CNBC Video
• CWTV
• Mediaset (all IEs)
• MovieClips
• National Geographic (all IEs)
• NBC: NBC News, NBC Olympics, NBC Olympics Stream, NBC Stations
• Scripps Networks (all IEs)
• Sprout
• Syfy
• ThePlatform
• generic, up to and including 17 (going further just got too much for now, maybe I'll come back to this some other time). To fix 18 would need changes in the base, since there are a number of fields the tests expect that just change way too often, such as views and subscriber counts.

The following IEs seem to be broken:

• Corus
• NBCSports
• CBC

NBCSportsVPlayer seems to not work with CPython 3.7, but works with CPython 3.8 and PyPy.

Fixes #

Template

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Fix or improvement to an extractor (Make sure to add/update tests)
• New extractor (Piracy websites will not be accepted)
• Core bug fix/improvement
• New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 65019f5

Summary

🛠️🌎🚫

This pull request updates and fixes the tests for various extractors, adding or changing keys in the test dictionaries to reflect the current status and metadata of the test URLs. It also skips some tests that fail due to geo-restriction, unavailability, or redirection of the test URLs. The affected extractors include aenetworks.py, cbc.py, cbs.py, cnbc.py, corus.py, generic.py, mediaset.py, nationalgeographic.py, nbc.py, scrippsnetworks.py, theplatform.py, amcnetworks.py, cwtv.py, movieclips.py, sprout.py, syfy.py, and theweatherchannel.py.

We're testing the extractors, one by one
We're skipping the broken ones, 'til they're done
We're adding the keys and the hashes, with care
We're heaving away, on the count of three, youtube-dl!

Walkthrough

• Add 'skip' keys to test dictionaries of various extractors to indicate reasons for skipping tests, such as geo-restriction, 404 errors, redirections, or broken URLs (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
• Update test URLs and test dictionaries of various extractors to use HTTPS instead of HTTP, to reflect changes in the video metadata, or to provide alternative URLs for the same video (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
• Add missing keys to test dictionaries of various extractors, such as 'thumbnail', 'chapters', 'duration', 'series', 'season_number', 'season', 'direct', 'timestamp', and 'display_id' (link, link, , link, , , , , , , link, link, link, link, link, link, link, link, link, link)
• Add comments to test dictionaries of CBCIE and CorusIE classes to indicate that the tests do not work and need a fix (link, link)

[bashonly]

Heads up, there are some more review suggestions in the "hidden conversations" -- I'd recommend going to the "Files changed" tab and adding them to a batch commit

[trainman261]

Thanks for the heads up, added that. Anything else?

[bashonly]

LGTM

[gamer191]

• To fix 18 would need changes in the base, since there are a number of fields the tests expect that just change way too often, such as views and subscriber counts.

You can just do:

'channel_follower_count': int,
'comment_count': int,
'like_count': int,
'view_count': int,

but I think this PR is big enough as is, and it's already been reviewed by bashonly, so lets save that for a future PR

PS: I posted a review comment on one of the above threads, in case you didn't see it