Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/Facebook] fix: Add dash-manifest URL to formats #7743

Merged
merged 2 commits into from Aug 1, 2023

Conversation

ringus1
Copy link
Contributor

@ringus1 ringus1 commented Aug 1, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds dash-manifest-url to formats if accessible.

Fixes #7742

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 8b88bcd

Summary

馃洜锔忦煄烇笍馃敆

Fix DASH extraction for some Facebook videos by passing mpd_url to _parse_mpd_formats in facebook.py

mpd_url added
To resolve relative paths
Winter of DASH woes

Walkthrough

  • Pass mpd_url parameter to _parse_mpd_formats to resolve relative URLs in MPD manifest (link)

@pukkandan pukkandan merged commit a854fbe into yt-dlp:master Aug 1, 2023
12 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Facebook] MPD playlist URL not provided in results
2 participants