New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/hungama] Overhaul extractors #7757
Conversation
Don't replace the old tests, add new tests for the new subdomain (they can be the same videos just with new URL format). Also be sure to run them to see if the site revamp broke anything |
When I run the tests using I tried rerunning the test multiple times as stated in step 6 but the error is still unresolved. Can you point me to the right direction on how to correctly run the tests? |
the test names are case sensitive |
If something helps: The website is playing with a lower quality max streaming support upto 192kbps. Audio bitrates of 96,128kbps are also returned. If editing the URL and changing 192 to 320, then I can download the higher bitrate m3u8 file. |
It turns out that it wasn't as simple as just updating the |
is it resolved? I tried updating to nightly build and its only download a placeholder ad for all the songs from un.hungama? |
@apstheironheart Looks like song extraction is broken for both |
Closes yt-dlp#7754 Authored by: Yalab7, bashonly
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Added
un
subdomain to the extractorhungama
by editing_VALID_URL
Fixes #7754
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at a18dd41
Summary
🎵🎬🛠️
Improved the Hungama extractor to handle a new subdomain for various media types. Modified a test case accordingly.
Walkthrough
_VALID_URL
patterns for theHungamaIE
,HungamaSongIE
, andHungamaAlbumPlaylistIE
classes to support theun.
subdomain (link, link, link)HungamaIE
class to use theun.
subdomain and match the updated pattern (link)