TBS Free (Japan) extractor #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Aug 3, 2023
bashonly
added
site-request
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
the metadata for the episode i used seems to have been changed a bit not sure what to make of that, to be honest
bashonly
approved these changes
Aug 4, 2023
i made the episode thing .get('is_phonetic'), the is_phonetic isnt always present
so with ['is_phonetic'] it fails and we get a generic 'Episode x' value
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Aug 4, 2023
bashonly
added
pending-review
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
pukkandan
approved these changes
Aug 6, 2023
bashonly
reviewed
Aug 14, 2023
bashonly
reviewed
Aug 14, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds extractors for Japanese TBS TV's catch-up site, TBS FREE.
It supports individual episodes of a programme, whole programme playlists, and category playlists that can contain both episodes and whole programmes.
TBS FREE is only available in Japan, but some metadata can be extracted internationally. The geoblock can be bypassed with a VPN.
Subtitle downloading won't work unless #7681 is merged.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 9cd12f7
Summary
🇯🇵📺🐍
This pull request adds support for downloading videos from the Japanese streaming service TBS. It introduces a new module
tbsjp.pythat defines three extractors for different types of TBS webpages. It also imports these extractors in_extractors.pyto register them with yt-dlp.Walkthrough
tbsjp.pyin_extractors.py(link)tbsjp.pythat inherit from InfoExtractor and implement _real_extract (link)