Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/youtube] Fix consent cookie #7774

Merged
merged 3 commits into from Aug 12, 2023
Merged

Conversation

coletdjnz
Copy link
Member

@coletdjnz coletdjnz commented Aug 4, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes #7594

CONSENT cookie no longer appears to be used.

YouTube now sets the SOCS cookie based on if you accept/reject all.

This sets the bare minimum SOCS cookie with a value of "accept all". We can't use reject all by default as some things don't work such as mixes. If a user wants to reject all then they can manually pass the cookie.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at e7be2f3

Summary

馃崻馃幍馃敀

Replace consent cookie with SOCS cookie for YouTube extraction. Fix YouTube mix extraction by setting SOCS cookie to 'CAI'. Add secure flag to SOCS cookie.

SOCS cookie set
YouTube mixes now working
Winter of consent

Walkthrough

  • Replace the consent cookie code with a simpler SOCS cookie code for YouTube extraction (link)

@coletdjnz coletdjnz added the site-bug Issue with a specific website label Aug 4, 2023
@coletdjnz coletdjnz merged commit 378ae9f into yt-dlp:master Aug 12, 2023
14 checks passed
@coletdjnz coletdjnz deleted the fix/youtube/consent branch August 12, 2023 04:26
zYxDevs pushed a commit to zYxDevs/NewLeaf that referenced this pull request Oct 29, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: [youtube] unable to extract initial player response
2 participants