Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zoom] Fixed screen share and added combined video #7847

Merged

Conversation

Mipsters
Copy link
Contributor

@Mipsters Mipsters commented Aug 15, 2023

Fixed screen share and added combined video

Downloading the screen share video was broken, so I fixed it

while fixing it I noticed that zoom added support for video with the camera and screen share combined, so I added support for it

I also made the combined video the default for videos with screen share

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at d104e95

Summary

🛠️🆕🌐

Fix and improve Zoom extractor. Add support for view_mp4_with_share format and use urllib to parse URLs and extract resolution in zoom.py.

To fix Zoom recordings extraction
And add a new format for action
We use urllib
To parse URLs nimbly
And get the resolution by fraction

Walkthrough

  • Fix share URL extraction by appending query parameter to JSON path (link)
  • Add new format for view MP4 with share URL that combines screen share and camera (link)
  • Change format ID for view MP4 URL to avoid confusion with share MP4 URL (link)
  • Extract resolution from URL using urllib module and static method (link, link)
  • Skip test case with invalid URL in zoom.py (link)

@bashonly bashonly added site-enhancement Feature request for some website site-bug Issue with a specific website labels Aug 21, 2023
@bashonly
Copy link
Member

Please test my changes and add a test that has a view_with_share format available

@bashonly bashonly added the needs-testing Patch needs testing label Sep 11, 2023
@seproDev
Copy link
Member

seproDev commented Nov 9, 2023

Can confirm this works. Here a test:

{
    'url': 'https://cityofdetroit.zoom.us/rec/share/VjE-5kW3xmgbEYqR5KzRgZ1OFZvtMtiXk5HyRJo5kK4m5PYE6RF4rF_oiiO_9qaM.UTAg1MI7JSnF3ZjX',
    'md5': 'bdc7867a5934c151957fb81321b3c024',
    'info_dict': {
        'id': 'VjE-5kW3xmgbEYqR5KzRgZ1OFZvtMtiXk5HyRJo5kK4m5PYE6RF4rF_oiiO_9qaM.UTAg1MI7JSnF3ZjX',
        'ext': 'mp4',
        'title': 'February 2022 Detroit Revenue Estimating Conference',
        'duration': 7299,
        'formats': 'mincount:3',
    },
}

@seproDev seproDev removed the needs-testing Patch needs testing label Nov 9, 2023
@bashonly bashonly added pending-review PR needs a review and removed pending-review PR needs a review labels Nov 9, 2023
@bashonly bashonly self-assigned this Nov 9, 2023
@bashonly bashonly merged commit 3906de0 into yt-dlp:master Nov 11, 2023
16 checks passed
@Mipsters
Copy link
Contributor Author

Thank you @seproDev
The only example I had was from my college and I couldn't share it

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants