New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/Hotstar] year added in hotstar metadata #7869
Conversation
Please fill out the template checklist or else the PR cannot be accepted:
|
And update tests |
yt_dlp/extractor/hotstar.py
Outdated
@@ -283,6 +283,7 @@ def _real_extract(self, url): | |||
return { | |||
'id': video_id, | |||
'title': video_data.get('title'), | |||
'year': video_data.get('year'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'year': video_data.get('year'), | |
'release_year': int_or_none(video_data.get('year')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion updated and ready to merge
The suggestion for the year has been updated. |
Update the tests with the |
are you talking about unittest? if it is it is done |
I am talking about these: _TESTS = [{
'url': 'https://www.hotstar.com/can-you-not-spread-rumours/1000076273',
'info_dict': {
'id': '1000076273',
'ext': 'mp4',
'title': 'Can You Not Spread Rumours?',
'description': 'md5:c957d8868e9bc793ccb813691cc4c434',
'timestamp': 1447248600,
'upload_date': '20151111',
'duration': 381,
'episode': 'Can You Not Spread Rumours?',
},
'params': {'skip_download': 'm3u8'},
}, {
'url': 'https://www.hotstar.com/tv/ek-bhram-sarvagun-sampanna/s-2116/janhvi-targets-suman/1000234847',
'info_dict': {
'id': '1000234847',
'ext': 'mp4',
'title': 'Janhvi Targets Suman',
'description': 'md5:78a85509348910bd1ca31be898c5796b',
'timestamp': 1556670600,
'upload_date': '20190501',
'duration': 1219,
'channel': 'StarPlus',
'channel_id': 3,
'series': 'Ek Bhram - Sarvagun Sampanna',
'season': 'Chapter 1',
'season_number': 1,
'season_id': 6771,
'episode': 'Janhvi Targets Suman',
'episode_number': 8,
}
}, { and all the rest |
All Done and working fine |
No, you haven't updated the tests. You need to actually run the tests, and then update them by adding
etc |
Test 3 Failed due to broken link and fixed with new link
Why do none of the tests return a |
I can write a new test for this if you want. |
Yes please do |
Authored by: Rajeshwaran2001
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
HotStar Year MetaData Added
Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at a7d72ea
Summary
✨🎥🇮🇳
Add
year
metadata field to HotStar extractor. This improves the accuracy and completeness of the video information extracted from the HotStar API.Walkthrough
year
field to video metadata fromvideo_data
dictionary (link)