-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wat.tv): remove MYTF1
context to remove "Permission insuffisante" error
#7898
Conversation
Add a test, unless the first test is still non-DRM and working (and if so, check if it needs to be updated) |
All links are very old (~10 years old) and not working anymore… for a long time. Do you have a simple command to run test just for this extractor? |
to run the 1st extractor test:
2nd and 3rd and so forth:
or run them all
Add a dict to the {
'url': 'https://www.tf1.fr/tmc/quotidien-avec-yann-barthes/videos/selah-sue-when-it-all-falls-down-en-live-pour-quotidien-67219751.html',
'info_dict': {
'id': '67219751',
'ext': 'mp4',
},
} Then run the test. It will fail and output the fields that are missing or incorrect. Copy those into your test dict, and run again. Repeat until the test passes. |
5106412
to
767274a
Compare
New test added 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to do a little fixup on the tests; I had given some bad instruction about adding a TF1
test to the Wat
extractor. In the future, please don't force push. You can push as many commits as you want to your PRs. Thanks for adding the test!
35d1045
to
8523ada
Compare
I've modified the test to be on |
What I'm saying is: don't do this. It makes it difficult to review the PR. |
Ok, noted for future PR here 👍 |
Thanks and sorry for the commit conflicts! 😇 |
Closes yt-dlp#7303 Authored by: davinkevin
Description of your pull request and other information
Modification in the
wat.py
extractor to be compatible with changes applied by the platform. See issue #7303 for more detail. I've just applied modification tested in this issue and locally.Fixes #7303
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 5106412
Summary
🛠️🔄❌
Fix wat.tv extraction by updating URL parameters in
yt_dlp/extractor/wat.py
Walkthrough
context
and updatepver
in JSON URL to fix video extraction from wat.tv (link)