Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Weverse preview endpoint if no auth provided #7924

Merged
merged 3 commits into from Aug 28, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Aug 21, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Change Weverse extractor to try and download videos using the preview endpoint if no credentials are provided.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 302a6c7

Summary

🔒🌐🛠️

Refactor weverse extractor to improve authentication and access handling, and add preview support.

The weverse extractor was due
For a refactor to make it more true
To the access rights logic
And the endpoints biologic
That provide previews for me and for you

Walkthrough

  • Move token check and login error to _call_api and _call_post_api functions (link)
  • Use alternative endpoints for previews without authentication or access rights (link)

@bashonly bashonly added the site-enhancement Feature request for some website label Aug 21, 2023
yt_dlp/extractor/weverse.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-review PR needs a review label Aug 21, 2023
@bashonly bashonly removed the pending-review PR needs a review label Aug 27, 2023
@bashonly bashonly merged commit c2d8ee0 into yt-dlp:master Aug 28, 2023
13 checks passed
@seproDev seproDev deleted the weverse-no-auth branch August 29, 2023 07:43
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants