Ensure dir existence for thumbnails and subtitles #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
11 tasks
bashonly
added
bug
bashonly
requested changes
Sep 26, 2023
Fixes output template `pl_thumbnail`. This problem went unnoticed while downloading videos because they're written into an already ensured dir, while playlists called the thumbnail writing method directly.
Riteo
force-pushed
the
check-dir-thumbs-subs
branch
from
a675ef1
to
adddcf2
Compare
|
There, I've applied all suggestions. Sorry for the delay! |
bashonly
approved these changes
Oct 11, 2023
bashonly
added
pending-review
Grub4K
approved these changes
Oct 13, 2023
Grub4K
removed
pending-review
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#8203 Authored by: Riteo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes output template
pl_thumbnail.Before this PR, trying to download a playlist with an output template of type
pl_thumbnailpointing to a missing subdirectory doesn't create it, instead erroring out.This problem went unnoticed while downloading videos because they're written into an already ensured dir, while playlists called the thumbnail writing method directly.
The subtitle change, while technically not required (playlists don't usually have subs) is done for consistency with all the other metadata writing methods. I can remove it if there's the need but it shouldn't hurt.Also I'm not really sure of the expected order of conditions, like, whether I should've put the checks right at the beginning or somewhere else. Please tell me if you'd like them somewhere else, I can change them no problem.
Example of a fixed invocation (tested with commit 4b3a6ef):
yt-dlp -vU --no-config --flat-playlist --write-thumbnail -o 'pl_thumbnail:test/%(id)s.%(ext)s' https://youtube.com/playlist?list=PLFG57rtsH8Jso3qfd5eO6egyBtW3nyvirverbose log before fix
verbose log after fix
Fixes... Nothing I could find with a couple of searches with various keywords.
Sorry, it's my first time here. Do you allow direct PRs?
CONTRIBUTING.MDdoesn't say much either. If that's not the case, I can open a simple issue right away.I hope that making the fix directly is better (merged or not I still need some workaround for this issue in the meantime so I'm not wasting time for myself anyways).
Closes #8203
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at a675ef1
Summary
馃悰馃摑馃毃
Add checks for output directory existence in
_write_subtitlesand_write_thumbnails. Update docstring of_write_thumbnails.Walkthrough
_write_thumbnailsto reflect this possibility (link)