Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/Rumble] fix: updated field extraction #8035

Merged
merged 3 commits into from Sep 16, 2023

Conversation

trislee
Copy link
Contributor

@trislee trislee commented Sep 6, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Updated the Rumble extractor

  • fixed extraction of view_count(HTML pattern had changed, now it uses tag in script head)
  • fixed extraction of like_count (HTML pattern had changed)
  • added extraction of dislike_count
  • updated fields in test info_dicts to work
  • added additional _EMBED_REGEX to RumbleIE to be able to correctly handle live videos, for example those on https://rumble.com/browse/live (this was required to fix an existing test)
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 042516d

Summary

🛠️🆕📺

Update rumble.py extractors and tests to match Rumble website changes. Fix test failures, add new fields, and support more embed types.

RumbleIE changes
Extract more fields and types
Winter of fixes

Walkthrough

  • Add like, dislike, and view count extraction to RumbleIE (link, link)
  • Update test cases of RumbleIE to match new extractor output and website layout (link, link, link, link, link)
  • Add new regex pattern to RumbleIE to support new videostream__link class (link)
  • Update test cases of RumbleEmbedIE to fix failures and improve accuracy (link, link, link, link)

… updated tests to work, added additional _EMBED_REGEX pattern to work for /browse/live page
@trislee trislee changed the title Fixes to Rumble extractor [extractor/Rumble] fix: updated field extraction Sep 6, 2023
yt_dlp/extractor/rumble.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rumble.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-enhancement Feature request for some website site-bug Issue with a specific website pending-fixes PR has had changes requested labels Sep 10, 2023
yt_dlp/extractor/rumble.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Sep 11, 2023
…or view_count

Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly added pending-review PR needs a review and removed pending-review PR needs a review labels Sep 11, 2023
@bashonly bashonly merged commit 23d829a into yt-dlp:master Sep 16, 2023
13 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants