[extractor/Funker530] fix: funker530 rumble embed link extraction and video download #8040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes the Funker530 rumble embed video download. Funker530 changed its rumble video embeds format and they couldn't be extracted by RumbleEmbedIE _extract_embed_urls method anymore because the direct link was not present in the webpage.
I fixed this by getting video id from the page and crafting an api request to rumble with that id and get the direct link to the video from the response.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 0a52904
Summary
🗑️🔄➕
Simplify Funker530 extractor by using generic extractor for direct video links. Remove unused imports of
RumbleEmbedIE
andcommon
, and add import ofgeneric
.Walkthrough
RumbleEmbedIE
withgeneric.GenericIE
for extracting video URLs (link,