Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/AbemaTV] Fix adding proxy parameters (fixes #8036) #8046

Merged
merged 2 commits into from Sep 16, 2023

Conversation

SevenLives
Copy link
Contributor

@SevenLives SevenLives commented Sep 7, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #8036

  • Fix the issue of downloading failure at AbemaTV site due to the addition of non-standard proxy parameters.
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 02c3220

Summary

🧹🛠️📺

Fix proxy issues with AbemaTV extractor by using clean_proxies function. Update add_opener to apply this function to ydl.proxies.

Oh we're the crew of the Python ship, and we sail the web so free
We use ydl to download our shows, from AbemaTV
But we need to clean our proxies well, or the license won't come through
So we import clean_proxies now, and we call it in add_opener too

Walkthrough

  • Import and use clean_proxies function to remove proxy headers from requests to AbemaTV license server (link, link)
  • Update add_opener function to pass cleaned proxies to rh._get_instance method (link)

@bashonly bashonly added site-bug Issue with a specific website regression Works in youtube-dl/older yt-dlp labels Sep 7, 2023
@coletdjnz coletdjnz merged commit 497bbbb into yt-dlp:master Sep 16, 2023
13 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Works in youtube-dl/older yt-dlp site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regarding the issue that adding irregular proxies might cause some sites to fail to download
3 participants