Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banbye support for URL's containing a hyphen #8059

Merged
merged 2 commits into from Sep 16, 2023

Conversation

kshitiz305
Copy link
Contributor

@kshitiz305 kshitiz305 commented Sep 8, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Example:
https://banbye.com/watch/v_kb6_o1Kyq-CD
yt-dlp only takes the part preceding the -:
[BanBye] v_kb6_o1Kyq: Downloading JSON metadata

What does work, is copying the video URL via right-click and feed that to yt-dlp.
But then it saves as 480 [480].mp4...

yt-dlp -vU --ignore-config "https://vod.banbye.com:31005/video/v_kb6_o1Kyq-CD/480.mp4"
[debug] Command-line config: ['-vU', '--ignore-config', 'https://vod.banbye.com:31005/video/v_kb6_o1Kyq-CD/480.mp4']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version nightly@2023.08.14.182926 [876b70c] (zip)
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.4.0-156-generic-x86_64-with-glibc2.29 (OpenSSL 1.1.1f 31 Mar 2020, glibc 2.31)
[debug] exe versions: ffmpeg N-111711-gd295b6b693-Nico-20230808 (fdk,setts), ffprobe N-111711-gd295b6b693-Nico-20230808, phantomjs 2.1.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.18.0, brotli-1.0.9, certifi-2023.07.22, mutagen-1.46.0, secretstorage-3.3.3, sqlite3-2.6.0, websockets-11.0.3, xattr-0.9.6
[debug] Proxy map: {}
[debug] Loaded 1863 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Available version: nightly@2023.08.14.182926, Current version: nightly@2023.08.14.182926
Current Build Hash: d66b5383fd468d11b0400e423e6db8704cc0f5fcfd3db28e06d0e821ceb3a546
yt-dlp is up to date (nightly@2023.08.14.182926)
[generic] Extracting URL: https://vod.banbye.com:31005/video/v_kb6_o1Kyq-CD/480.mp4
[generic] 480: Downloading webpage
[debug] Identified a direct video link
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 480: Downloading 1 format(s): mp4
[debug] Invoking http downloader on "https://vod.banbye.com:31005/video/v_kb6_o1Kyq-CD/480.mp4"
[download] Destination: 480 [480].mp4
[download] 100% of 88.91MiB in 00:00:08 at 10.24MiB/s
Fixes #7895

Banbye support for URL's containing a hyphen

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 2ad6270

Summary

馃枈锔忦煄烇笍馃悰

Fix extraction of videos with hyphens in id on banbye.py extractor. Update the _VALID_URL pattern to match them.

_VALID_URL changed
Hyphens in video id
Autumn leaves fall fast

Walkthrough

  • Allow hyphens in video id for Banbye extractor (_VALID_URL in link)

@bashonly
Copy link
Member

bashonly commented Sep 8, 2023

Add a test for a URL with hyphen in the ID

@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Sep 8, 2023
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Sep 13, 2023
@coletdjnz coletdjnz removed the pending-review PR needs a review label Sep 16, 2023
@coletdjnz coletdjnz merged commit 578a82e into yt-dlp:master Sep 16, 2023
13 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banbye support for URL's containing a hyphen
3 participants