[ie/bpb] Support more urls and extract more metadata #8119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Sep 15, 2023
Comment on lines
+118
to
+125
| def _parse_vue_attributes(self, name, string, video_id): | ||
| attributes = extract_attributes(self._search_regex(rf'(<{name}(?:"[^"]*?"|[^>])*>)', string, name)) | ||
|
|
||
| for key, value in attributes.items(): | ||
| if key.startswith(':'): | ||
| attributes[key] = self._parse_json(value, video_id, transform_source=js_to_json, fatal=False) | ||
|
|
||
| return attributes |
There was a problem hiding this comment.
Just a note that it might be useful to eventually generalize this and add it as an InfoExtractor helper method, since it is very similar to ZaikoBaseIE._parse_vue_element_attrs (but not similar enough as-is)
bashonly
added
pending-review
bashonly
approved these changes
Sep 15, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: Grub4K
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR allows all possible url formats and extracts more metadata.
Fixes #8093
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 73f6743
Summary
🎥🌐✨
This pull request improves the
BpbIEextractor to support more media types and metadata from the Bundeszentrale für politische Bildung website. It also fixes a bug in thedetermine_extfunction by adding a missing entry for video/ogg in themimetype2extdictionary.Walkthrough
utilsmodule to map video/ogg to ogv extension (link)