Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/RTVSLO] Fix format extraction #8131

Merged
merged 3 commits into from Sep 17, 2023
Merged

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Sep 16, 2023

Fixes #8020

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 91a4b7d

Summary

🛠️🧪🚫

Enhance the rtvslo extractor to handle more formats and protocols, and update tests and imports.

The rtvslo extractor was slow
And had some issues to undergo
So they imported utils
And updated the rules
To skip protocols they don't know

Walkthrough

  • Import int_or_none function to parse integers from metadata (link)
  • Update ext field of test case to match actual video format (link)
  • Add test case for 365.rtvslo.si domain with expected metadata (link)
  • Skip unsupported f4m and dash protocols when extracting wowza formats (link)
  • Refactor and improve format extraction from mediaFiles list using traverse_obj function and add support for hls_sec stream (link)

@bashonly bashonly added the site-bug Issue with a specific website label Sep 16, 2023
Copy link
Member

@coletdjnz coletdjnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bashonly bashonly merged commit 94389b2 into yt-dlp:master Sep 17, 2023
14 checks passed
@bashonly bashonly deleted the fix/rtvslo branch December 7, 2023 15:16
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTVSLO fails on some links
2 participants