Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/web.archive:vlive] Remove extractor #8132

Merged
merged 1 commit into from Sep 17, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Sep 16, 2023

Closes #8122

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 6b14fb2

Summary

馃殮馃摑鉁傦笍

This pull request refactors the codebase to split the extractors into different files based on their domains or categories. It moves the VLiveWebArchiveIE extractor class from _extractors.py to archiveorg.py and updates the comment of the process_subtitles method in naver.py accordingly. This improves the organization and readability of the code.

Oh, we're the brave extractors of the web
We fetch the videos from every site and thread
But when the code gets messy and too long
We move the classes to where they belong

Walkthrough

  • Relocate VLiveWebArchiveIE extractor class from _extractors.py to archiveorg.py to group it with other web.archive.org extractors (link, link)
  • Remove unused import of NaverBaseIE from archiveorg.py to clean up the code (link)
  • Update comment of process_subtitles method in naver.py to remove reference to VLiveWebArchiveIE (link)

@bashonly bashonly added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Sep 16, 2023
@bashonly bashonly merged commit 9652bca into yt-dlp:master Sep 17, 2023
14 checks passed
@bashonly bashonly deleted the cleanup/archiveorg-vlive branch December 7, 2023 15:16
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VLiveWebArchiveIE no longer works, archive.org excluded/banned all vlive links --> vlivearchive.com
2 participants