New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Cineverse IEs #8146
Merged
Merged
add Cineverse IEs #8146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covers cineverse.com, asiancrush.com, dovechannel.com, screambox.com, midnightpulp.com, fandor.com, and retrocrush.tv, all of which run on the same software. It replaces AsianCrushIE. (hopefully) closes yt-dlp#8109
garret1317
added
site-request
Request to support a new website
geo-blocked
Content is geo-blocked
labels
Sep 18, 2023
bashonly
requested changes
Sep 21, 2023
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
bashonly
approved these changes
Sep 22, 2023
bashonly
added
pending-review
PR needs a review
and removed
pending-fixes
PR has had changes requested
labels
Sep 22, 2023
coletdjnz
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Grub4K
requested changes
Sep 23, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Also removes AsianCrushIE and AsianCrushPlaylistIE (URLs do not work anymore & old IDs are unavailable). Closes yt-dlp#8109 Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR adds an extractor for https://www.cineverse.com and its associated sites.
It replaces the Asiancrush extractors. See this comment for more info
Closes #8109
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at 8a96e8c
Summary
馃帴馃寧馃攧
Replace
asiancrush
extractor withcineverse
extractor to support more websites that use the same API. Addcineverse
module that defines theCineverseIE
andCineverseDetailsIE
classes for extracting video and playlist data from the Cineverse API. Deleteasiancrush.py
and update_extractors.py
accordingly.Walkthrough
AsianCrushIE
andAsianCrushPlaylistIE
withCineverseIE
andCineverseDetailsIE
to support multiple websites that use the same API (link, link)asiancrush.py
as it is no longer needed (link)cineverse.py
to define the new extractors for the Cineverse API (link)