Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cineverse IEs #8146

Merged
merged 7 commits into from Sep 23, 2023
Merged

add Cineverse IEs #8146

merged 7 commits into from Sep 23, 2023

Conversation

garret1317
Copy link
Collaborator

@garret1317 garret1317 commented Sep 18, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR adds an extractor for https://www.cineverse.com and its associated sites.
It replaces the Asiancrush extractors. See this comment for more info

Closes #8109

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 8a96e8c

Summary

馃帴馃寧馃攧

Replace asiancrush extractor with cineverse extractor to support more websites that use the same API. Add cineverse module that defines the CineverseIE and CineverseDetailsIE classes for extracting video and playlist data from the Cineverse API. Delete asiancrush.py and update _extractors.py accordingly.

Oh we are the coders of the Cineverse module
We inherit from the base class and extract the JSON
We handle the errors and the geo-restrictions
And we return the video and playlist information

Walkthrough

  • Replace AsianCrushIE and AsianCrushPlaylistIE with CineverseIE and CineverseDetailsIE to support multiple websites that use the same API (link, link)
  • Delete asiancrush.py as it is no longer needed (link)
  • Add cineverse.py to define the new extractors for the Cineverse API (link)

covers cineverse.com, asiancrush.com, dovechannel.com, screambox.com,
midnightpulp.com, fandor.com, and retrocrush.tv, all of which run on the
same software. It replaces AsianCrushIE.

(hopefully) closes yt-dlp#8109
@garret1317 garret1317 added site-request Request to support a new website geo-blocked Content is geo-blocked labels Sep 18, 2023
@garret1317 garret1317 changed the title Cineverse add Cineverse IEs Sep 18, 2023
@bashonly bashonly self-requested a review September 18, 2023 23:46
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Sep 21, 2023
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Sep 22, 2023
Copy link
Member

@coletdjnz coletdjnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yt_dlp/extractor/cineverse.py Outdated Show resolved Hide resolved
yt_dlp/extractor/cineverse.py Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label Sep 23, 2023
@bashonly bashonly merged commit 1559194 into yt-dlp:master Sep 23, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Also removes AsianCrushIE and AsianCrushPlaylistIE (URLs do not work anymore & old IDs are unavailable).

Closes yt-dlp#8109
Authored by: garret1317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geo-blocked Content is geo-blocked site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[asiancrush] Extractor not working. Update due?
4 participants