Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update minimum recommended Python version #8183

Merged
merged 3 commits into from Sep 24, 2023

Conversation

Grub4K
Copy link
Member

@Grub4K Grub4K commented Sep 23, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at e4ee0b5

Summary

⚠️⬆️🛠️

Raise the minimum recommended Python version to 3.8 and warn users of deprecated versions and platforms. Add a new function _get_system_deprecation to update.py and use it in YoutubeDL.py. Update the changelog_override.json file to reflect the change.

To update the changelog, we strive
To inform users of Python 3.5
That they should upgrade soon
Or they'll miss the new boon
Of the _get_system_deprecation drive

Walkthrough

  • Add a new function _get_system_deprecation to update.py that returns a deprecation message based on the current Python version and platform (link)
  • Import the _get_system_deprecation function in YoutubeDL.py and use it to replace the previous version check and message (link, link)
  • Add a manual entry to changelog_override.json to inform the users about the raised minimum recommended Python version and the deprecated platforms, and provide a link to the issue where the decision was discussed (link)

@Grub4K Grub4K added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Sep 23, 2023
@gamer191
Copy link
Collaborator

Python versions 3.7+ (CPython and PyPy) are supported. Other versions and implementations may or may not work correctly.
should also be updated imo
And perhaps also a few mentions in the wiki, but I don't have time to find them right now

@Grub4K Grub4K merged commit 61bdf15 into yt-dlp:master Sep 24, 2023
16 checks passed
@Grub4K Grub4K deleted the 3.7-deprecation branch September 24, 2023 01:21
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants