Various radiko enhancements #8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsid is an ID. Currently all yt-dlp users talk to the stream apis as the same person. this commit generates a random id with secrets.token_hex() instead.
This filters for streams that match the onair status of the current download i'm not really sure what the bottom stuff does so i've left it alone
only for outside japan, not for prefecture-level
there's an api for this, we don't have to blindly try and download twice
this API seemingly always gives "happy path" streams: The live streams work perfectly fine with ffmpeg. The catch-up isn't streamed as-live, it's regular non-live hls that works with yt-dlp's hls downloader (though annoyingly not with mpv).
garret1317
added
geo-blocked
|
actually yes do skip e9117f0 |
bashonly
requested changes
Oct 3, 2023
This reverts commit e9117f0.
Co-Authored-By: bashonly <bashonly@bashonly.com>
|
oh bugger ive broken the indentation |
bashonly
approved these changes
Oct 3, 2023
Grub4K
approved these changes
Oct 5, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
These patches improve the
radikoextractor using things I've learnt while developing my plugin yt-dlp-rajiko.Hopefully the commit messages explain each change well enough, feel free to ask if not.
e9117f0 sort-of-fixes #6090, since the new format downloads with yt-dlp's hls downloader rather than ffmpeg.
However it could possibly break someone's workflow, as the extractor now extracts completely different formats. This commit can be skipped if you'd like.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at e9117f0
Summary
馃寪馃晵馃攽
Enhance the
radiko.pyextractor to handle different types of streams, check geo-restrictions, and streamline the code.Walkthrough
_auth_clientmethod to_negotiate_token(link)timefreeattribute for live and timefree streams (link, link)lsidparameter for playlist URL (link, link)liveargument from_extract_m3u8_formatsmethod call (link)is_livekey tolive_statusand set it towas_livefor timefree streams (link)