New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/youtube] Raise a warning for Incomplete Data
error instead by default
#8238
Merged
coletdjnz
merged 7 commits into
yt-dlp:master
from
coletdjnz:fix/yt-imcomplete-data-warn
Oct 3, 2023
Merged
[ie/youtube] Raise a warning for Incomplete Data
error instead by default
#8238
coletdjnz
merged 7 commits into
yt-dlp:master
from
coletdjnz:fix/yt-imcomplete-data-warn
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grub4K
requested changes
Oct 1, 2023
Grub4K
approved these changes
Oct 2, 2023
bashonly
approved these changes
Oct 2, 2023
bashonly
approved these changes
Oct 2, 2023
bashonly
approved these changes
Oct 2, 2023
Grub4K
approved these changes
Oct 2, 2023
Grub4K
approved these changes
Oct 2, 2023
bashonly
approved these changes
Oct 2, 2023
Grub4K
approved these changes
Oct 2, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
yt-dlp#8238) Closes yt-dlp#8206 Adds `raise_incomplete_data` extractor arg to revert this behaviour and raise an error. Authored by: coletdjnz Co-authored-by: Simon Sawicki <contact@grub4k.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #8206
This is something I've been thinking of doing for a while.
Adds an extractor arg
raise_incomplete_data
to revert this change.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 7d04b5f
Summary
🛠️⚠️ 📺
This pull request adds a new option
raise_incomplete_data
to theyoutube
extractor, which lets the user decide how to handle incomplete data from the YouTube API. It also modifies theyt_dlp/extractor/youtube.py
file to use a newRetryManager
instance to retry or report the incomplete data error. The goal is to improve the extractor's performance and user experience.Walkthrough
raise_incomplete_data
option toyoutube
extractor (link, link)