Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/youtube] Raise a warning for Incomplete Data error instead by default #8238

Merged
merged 7 commits into from Oct 3, 2023

Conversation

coletdjnz
Copy link
Member

@coletdjnz coletdjnz commented Sep 29, 2023

Workaround for #8206

This is something I've been thinking of doing for a while.

Adds an extractor arg raise_incomplete_data to revert this change.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 7d04b5f

Summary

🛠️⚠️📺

This pull request adds a new option raise_incomplete_data to the youtube extractor, which lets the user decide how to handle incomplete data from the YouTube API. It also modifies the yt_dlp/extractor/youtube.py file to use a new RetryManager instance to retry or report the incomplete data error. The goal is to improve the extractor's performance and user experience.

raise_incomplete_data
Choose error or warning
Autumn leaves falling

Walkthrough

  • Add raise_incomplete_data option to youtube extractor (link, link)

@coletdjnz coletdjnz added high-priority site-enhancement Feature request for some website labels Sep 29, 2023
yt_dlp/extractor/youtube.py Outdated Show resolved Hide resolved
yt_dlp/extractor/youtube.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@coletdjnz coletdjnz merged commit eb5bdbf into yt-dlp:master Oct 3, 2023
16 checks passed
@coletdjnz coletdjnz deleted the fix/yt-imcomplete-data-warn branch October 3, 2023 06:42
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
yt-dlp#8238)

Closes yt-dlp#8206

Adds `raise_incomplete_data` extractor arg to revert this behaviour and raise an error.

Authored by: coletdjnz
Co-authored-by: Simon Sawicki <contact@grub4k.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants