[ie/lbry] Extract uploader_id
#8244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader. These make good fit for %(channel)s or, for the normalized form, %(uploader_id)s as a human-readable counterpart of %(channel_id)s NB: For backward compatibility, signing_channel.value.title it's unsure when does this field exist.
bashonly
requested changes
Sep 30, 2023
bashonly
added
pending-fixes
bashonly
changed the title
uploader_id
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
|
|
Done, but please note that one test is broken (not fetch the 3 formats and not download the expected file), but this also affect master and is independent from this PR. |
bashonly
approved these changes
Oct 6, 2023
bashonly
added
pending-review
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#123 Authored by: drzraf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds
%(channel)sand%(upload_id)sfor lbryFixes #123
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at b0c3420
Summary
🛠️🔄🧑🎤
Fix channel and uploader extraction in
lbry.py. Make the fields consistent with the YouTube extractor.Walkthrough
channel_id,channel_url,uploader, anduploader_urlfields from theclaimandsigning_channelkeys in the stream metadata (link)channel_namefield as theuploaderif thesigning_channelkey is missing or invalid (link)