Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JioSaavn] Add extractor #8307

Merged
merged 11 commits into from Nov 15, 2023
Merged

[JioSaavn] Add extractor #8307

merged 11 commits into from Nov 15, 2023

Conversation

awalgarg
Copy link
Contributor

@awalgarg awalgarg commented Oct 8, 2023

Description of your pull request and other information

JioSaavn is a large streaming service primarily serving Indian music.

Original PR in youtube-dl: ytdl-org/youtube-dl#20870, unfortunately it wasn't merged back then. I've been maintaining it in my personal fork since and it works well.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 2df4020

Summary

馃幍馃嚠馃嚦馃啎

Add support for JioSaavn streaming service. Add jiosaavn.py module with extractors for songs and albums. Import these extractors in _extractors.py.

yt-dlp expands
JioSaavn songs and albums
now in autumn breeze

Walkthrough

  • Add support for JioSaavn streaming service (link, link)
  • Import JioSaavnSongIE and JioSaavnAlbumIE classes from jiosaavn.py module in _extractors.py (link)
  • Define JioSaavnBaseInfoExtractor class to extract initial JSON data from webpage (link)
  • Define JioSaavnSongIE class to extract information and media URL of a single song (link)
  • Define JioSaavnAlbumIE class to extract information and URLs of all songs in an album (link)
  • Add tests and documentation for the new classes (link)

@bashonly bashonly self-requested a review October 8, 2023 15:56
@bashonly bashonly added the site-request Request to support a new website label Oct 8, 2023
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Nov 1, 2023
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
yt_dlp/extractor/jiosaavn.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Nov 15, 2023
@bashonly bashonly self-assigned this Nov 15, 2023
@bashonly bashonly merged commit b530118 into yt-dlp:master Nov 15, 2023
16 checks passed
@awalgarg awalgarg deleted the awal/saavn branch November 21, 2023 18:02
@awalgarg
Copy link
Contributor Author

Thanks for fixing it up and merging! I've been traveling so couldn't take a look earlier.

aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants