New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JioSaavn] Add extractor #8307
Merged
Merged
[JioSaavn] Add extractor #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seproDev
requested changes
Nov 1, 2023
bashonly
requested changes
Nov 15, 2023
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
bashonly
reviewed
Nov 15, 2023
bashonly
approved these changes
Nov 15, 2023
bashonly
reviewed
Nov 15, 2023
bashonly
reviewed
Nov 15, 2023
bashonly
reviewed
Nov 15, 2023
Thanks for fixing it up and merging! I've been traveling so couldn't take a look earlier. |
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: awalgarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
JioSaavn is a large streaming service primarily serving Indian music.
Original PR in youtube-dl: ytdl-org/youtube-dl#20870, unfortunately it wasn't merged back then. I've been maintaining it in my personal fork since and it works well.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at 2df4020
Summary
馃幍馃嚠馃嚦馃啎
Add support for JioSaavn streaming service. Add
jiosaavn.py
module with extractors for songs and albums. Import these extractors in_extractors.py
.Walkthrough
jiosaavn.py
module in_extractors.py
(link)