Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbs.co.kr extractor #8326

Merged
merged 8 commits into from Nov 11, 2023
Merged

Add sbs.co.kr extractor #8326

merged 8 commits into from Nov 11, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Oct 11, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Added extractor for SBS a Korean TV network.
I don't like the class names, but couldn't come up with anything better.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at acae621

Summary

馃嚢馃嚪馃帴馃啎

This pull request adds support for extracting videos from the South Korean broadcaster SBS's websites, such as allvod.sbs.co.kr and programs.sbs.co.kr. It introduces a new module sbscokr.py that defines three new extractor classes, and imports them in _extractors.py.

SBSCoKrIE class
Extracts videos from SBS
Winter entertainment

Walkthrough

  • Add support for extracting videos from SBS websites (link, link)
    • Import the classes SBSCoKrIE, SBSCoKrAllvodProgramIE, and SBSCoKrProgramsVodIE from the module sbscokr.py in _extractors.py (link)
    • Define the classes SBSCoKrIE, SBSCoKrAllvodProgramIE, and SBSCoKrProgramsVodIE in sbscokr.py (link)

@bashonly bashonly self-requested a review October 11, 2023 09:17
@bashonly bashonly added the site-request Request to support a new website label Oct 11, 2023
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
yt_dlp/extractor/sbscokr.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Nov 9, 2023
seproDev and others added 3 commits November 9, 2023 18:47
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested pending-review PR needs a review labels Nov 9, 2023
@bashonly bashonly self-assigned this Nov 11, 2023
@bashonly bashonly merged commit 25a4bd3 into yt-dlp:master Nov 11, 2023
16 checks passed
@seproDev seproDev deleted the sbs branch November 11, 2023 19:57
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants