New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extractors] Add maariv.co.il extractor #8331
Conversation
Co-authored-by: garret <garret1317@yandex.com>
Co-authored-by: garret <garret1317@yandex.com>
Co-authored-by: garret <garret1317@yandex.com>
Co-authored-by: garret <garret1317@yandex.com>
Co-authored-by: garret <garret1317@yandex.com>
match embed regex instead of article url Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@seproDev I merged your suggestions. I ran a test download, while it downloads and lists formats just fine, however it fails the test
I have no idea what this means exactly? what do i need to change? |
@amir16yp I fixed some things. Pull and try again the tests will fail at first, but should output the missing info_dict fields that you can copy/paste |
Authored by: amir16yp
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds an extractor for https://maariv.co.il, an Israeli news website.
The generic extractor does not extract videos from articles so I decided to reverse engineer the site and make my own extractor. The extractor is by no means perfect but is suitable enough for it to be used now, I'd appreciate any feedback on this before merging.
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 10ea327
Summary
📥📄🎥
Add support for extracting videos from maariv.co.il articles. Create a new file
maariv.py
that defines theMaarivIE
extractor and import it in_extractors.py
.Walkthrough
MaarivIE
class frommaariv.py
in_extractors.py
(link)MaarivIE
class inmaariv.py
(link)