-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/bilibili] Support interactive videos and course videos #8343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to get around to reviewing this!
I have some questions about _get_divisions()
that could probably be answered if you provide an example API response
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Any plan on releasing this soon? The latest build upon 2023.11.16 looks still yet coming with the Cheese categorization support. |
|
Closes yt-dlp#6135, Closes yt-dlp#8428 Authored by: c-basalt
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Add supports for interactive split-path videos. Fixes #6135
Interactive videos are composed of separate sections that can jump to each other via overlay buttons. Each section is a video with a unique
cid
but not a unique URL like typical?p=xxx
anthology (webpage uses a cookie to access saved progress on server). This PR extract these interactive videos as playlist results.Add better error hints for patreon-like "supporter-only" videos, login-user-only videos, "shadow" geo-blocked videos, and one testcase each for reference.
Add login hint for empty CC subtitle since the site appears to now hide subtitles from guest visitors.
Add geo-free, premium-free testcases for Bangumi extractors. Fix metainfo extraction glitches in Bangumi extractors.
Add
BilibiliCheeseIE
andBilibiliCheeseSeasonIE
to support course videos.Add detection of 301 redirects for
BiliBiliIE
. Fixes #8428Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at ae38877
Summary
✨💰🇨🇳
Added support for Bilibili Cheese, a paid subscription service on Bilibili. Imported
BilibiliCheeseIE
andBilibiliCheeseSeasonIE
frombilibili.py
to_extractors.py
.Walkthrough