Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/twitter:broadcast] Update extraction #8383

Merged
merged 7 commits into from Nov 11, 2023

Conversation

HitomaruKonpaku
Copy link
Contributor

@HitomaruKonpaku HitomaruKonpaku commented Oct 19, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Update twitter:broadcast extraction data on

  • title
  • timestamp
  • uploader_id use twitter username
  • thumbnails
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 05c0179

Summary

🕒🖼️🐦

Improve metadata extraction for Periscope and Twitter broadcasts. Use additional fields from the broadcast data to provide more reliable and informative timestamp, thumbnail, title, and uploader information in periscope.py and twitter.py.

Periscope data
More fields to extract and use
Winter of updates

Walkthrough

  • Extract timestamp and thumbnails from Periscope broadcast data (link)
  • Add more metadata to Twitter broadcast info (link)

@Grub4K Grub4K self-requested a review October 19, 2023 08:48
@bashonly bashonly added the site-enhancement Feature request for some website label Oct 21, 2023
@bashonly bashonly self-requested a review October 21, 2023 13:52
Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will need to be updated

yt_dlp/extractor/periscope.py Outdated Show resolved Hide resolved
yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Nov 4, 2023
yt_dlp/extractor/periscope.py Outdated Show resolved Hide resolved
yt_dlp/extractor/twitter.py Show resolved Hide resolved
yt_dlp/extractor/twitter.py Outdated Show resolved Hide resolved
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yt_dlp/extractor/periscope.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 4, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly self-assigned this Nov 9, 2023
@bashonly bashonly removed the pending-review PR needs a review label Nov 9, 2023
@bashonly bashonly merged commit 7d337ca into yt-dlp:master Nov 11, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants