Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite OnDemandKorea Extractor #8386

Merged
merged 13 commits into from Nov 11, 2023
Merged

Rewrite OnDemandKorea Extractor #8386

merged 13 commits into from Nov 11, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Oct 19, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Requires Python 3.8 due to the use of the walrus operator.
Not entirely sure if the series check inside traverse_obj is the most elegant way to write this.

Both were addressed in review.

Fixes #8374

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 19aa313

Summary

🆕🔄✨

Add a new extractor class for OnDemandKorea programs and rewrite the existing extractor class for OnDemandKorea videos. The new classes use a different API endpoint, support more features and formats, and handle errors better. Update the tests and the import statement in _extractors.py accordingly.

ondemandkorea.py
New API, more features
Autumn of improvement

Walkthrough

  • Import and register new extractor class for OnDemandKorea programs (link)
  • Rewrite extractor classes for OnDemandKorea videos and programs using a different API endpoint and URL pattern (link)

@bashonly bashonly added the site-bug Issue with a specific website label Oct 21, 2023
@bashonly bashonly self-requested a review October 21, 2023 13:53
yt_dlp/extractor/ondemandkorea.py Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Nov 9, 2023
yt_dlp/extractor/ondemandkorea.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 9, 2023
seproDev and others added 2 commits November 9, 2023 22:15
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly removed the pending-review PR needs a review label Nov 11, 2023
@bashonly bashonly self-assigned this Nov 11, 2023
@bashonly bashonly merged commit 05adfd8 into yt-dlp:master Nov 11, 2023
16 checks passed
@seproDev seproDev deleted the odk-rewrite branch November 11, 2023 19:58
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to download from ondemandkorea.com
2 participants