Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[laxarxames] Add extractor #8412

Merged
merged 12 commits into from
Nov 11, 2023
Merged

[laxarxames] Add extractor #8412

merged 12 commits into from
Nov 11, 2023

Conversation

aniolpages
Copy link
Contributor

@aniolpages aniolpages commented Oct 22, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Add extractor for La Xarxa+, a Catalan OTT with content from local TV stations

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 71229c9

Summary

🆕🎥🏀

Add a new extractor for laxarxames.cat, a Catalan sports streaming website. The extractor handles login and parses Brightcove video sources from the API. The extractor is defined in laxarxames.py and imported in _extractors.py.

LaXarxaMesIE
New extractor for sports site
Login, parse, download

Walkthrough

  • Add a new extractor for laxarxames.cat (link, link)
  • Import the LaXarxaMesIE class from laxarxames.py in _extractors.py (link)
  • Create the laxarxames.py file and define the LaXarxaMesIE class (link)

@bashonly bashonly self-requested a review October 22, 2023 18:43
@bashonly bashonly added the site-request Request to support a new website label Oct 22, 2023
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
aniolpages and others added 3 commits November 1, 2023 12:13
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Copy link
Member

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be everything from me.

yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Nov 4, 2023
@aniolpages
Copy link
Contributor Author

Thank you again for your help, @seproDev !

Copy link
Member

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 5, 2023
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
yt_dlp/extractor/laxarxames.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Nov 5, 2023
@bashonly bashonly removed the pending-fixes PR has had changes requested label Nov 5, 2023
@bashonly bashonly self-assigned this Nov 5, 2023
@bashonly bashonly merged commit 312a2d1 into yt-dlp:master Nov 11, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants